Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS EKS kubernetes resources #228

Merged
merged 2 commits into from
Feb 21, 2024
Merged

AWS EKS kubernetes resources #228

merged 2 commits into from
Feb 21, 2024

Conversation

DaMandal0rian
Copy link
Contributor

@DaMandal0rian DaMandal0rian commented Dec 22, 2023 •
edited
Loading

The PR adds terraform declarations for AWS EKS managed kubernetes clusters on AWS infrastructure.

  • Cluster and node pool resources are created
  • IAM role and KMS key management
  • Bottlerocket optimized cluster with custom AMI for better performance and security
  • gitops with argocd
  • enable coredns, prometheus, cert-manager addons

closes #143

@autonomys autonomys deleted a comment from gitguardian bot Dec 22, 2023
@autonomys autonomys deleted a comment from gitguardian bot Dec 22, 2023
@autonomys autonomys deleted a comment from gitguardian bot Dec 22, 2023
@gitguardian GitGuardian
Copy link

gitguardian bot commented Jan 8, 2024 •
edited
Loading

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@DaMandal0rian DaMandal0rian marked this pull request as ready for review January 8, 2024 12:27
@DaMandal0rian DaMandal0rian marked this pull request as draft January 8, 2024 13:42
@DaMandal0rian DaMandal0rian marked this pull request as ready for review January 8, 2024 14:09
@DaMandal0rian DaMandal0rian mentioned this pull request Jan 9, 2024
Closed
vedhavyas
vedhavyas reviewed Jan 19, 2024
View reviewed changes
Copy link
Contributor

@vedhavyas vedhavyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. Left some suggestions

eks/base/eks_managed_node_group/variables.tf Outdated
description = "List of AWS IAM accounts to add to aws-auth configmap"
default = []

# i.e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need these commented out default ?

eks/base/eks_managed_node_group/variables.tf Outdated

[settings.kubernetes.node-labels]
# todo: add label to the nodes
app1 = "explorer-squid"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see these applications hard coded. Can we get these from config instead?

Copy link
Contributor Author

@DaMandal0rian DaMandal0rian Jan 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I have refactored it now, created blue/green environments and added argocd too. These hardcoded values are passed as input variables now.

@DaMandal0rian
EKS managed kubernetes
bf65867 
add blue/green deployment and argocd

- use new eks module
- declarative deployments with argocd
- blue green envs
- prod env
- refactor userdata and remove hardcoded 
- network module and variables fix
@DaMandal0rian DaMandal0rian merged commit 5a3b98a into main Feb 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedhavyas vedhavyas vedhavyas approved these changes

@nazar-pc nazar-pc Awaiting requested review from nazar-pc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup kubernetes cluster for explorer and workloads
2 participants
@DaMandal0rian @vedhavyas