Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Ci release windows fix #256

Merged
merged 7 commits into from
Sep 7, 2023
Merged

Ci release windows fix #256

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
930253f
Update release.yml
jfrank-summit Aug 26, 2023
778a6aa
Merge branch 'main' into ci-release-windows-fix
DaMandal0rian Sep 1, 2023
e2b7e87
add azuresigntool codesign process
DaMandal0rian Sep 5, 2023
4f725a6
Update to gemini-3f-2023-sep-05 subspace sdk version
ParthDesai Sep 6, 2023
fe0fdac
Merge branch 'main' into ci-release-windows-fix
DaMandal0rian Sep 6, 2023
f0a47de
remove azuresigntool installation
DaMandal0rian Sep 7, 2023
73c49a9
Merge branch 'main' into ci-release-windows-fix
DaMandal0rian Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,13 +145,8 @@ jobs:
if: runner.os == 'macOS'

- name: Sign Application (Windows)
uses: skymatic/code-sign-action@500ce4f8261ca9bd8f85978c1652b34fb511bdf4 # @v2.0.1
with:
certificate: "${{ secrets.WINDOWS_CERTIFICATE }}"
password: "${{ secrets.WINDOWS_CERTIFICATE_PASSWORD }}"
certificatesha1: "${{ secrets.WINDOWS_CERTIFICATE_SHA }}"
folder: "${{ matrix.build.production_target }}"
# Allow code signing to fail on non-release builds and in non-subspace repos (forks)
run: |
AzureSignTool sign --azure-key-vault-url "${{ secrets.AZURE_KEY_VAULT_URI }}" --azure-key-vault-client-id "${{ secrets.AZURE_CLIENT_ID }}" --azure-key-vault-client-secret "${{ secrets.AZURE_CLIENT_SECRET }}" --azure-key-vault-tenant-id "${{ secrets.AZURE_TENANT_ID }}" --azure-key-vault-certificate "${{ secrets.AZURE_CERT_NAME }}" --file-digest sha512 --timestamp-rfc3161 http://timestamp.digicert.com -v "${{ matrix.build.production_target }}/pulsar.exe"
continue-on-error: ${{ github.repository_owner != 'subspace' || github.event_name != 'push' || github.ref_type != 'tag' }}
if: runner.os == 'Windows'

Expand Down