This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The structure of crossterm::event::KeyEvent is the following:
The current implementation is ignoring the field
kind
. This could lead to issues as the one described at #223. In this other issue you could check similar problems: crossterm-rs/crossterm#797Solution
The solution is quite simple, keep the same KeyCode filtering but restrict them to only
Press
kind events.