This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Combine SDK and CLI Part: 2 #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParthDesai
force-pushed
the
combine-sdk-and-cli-part-2
branch
from
0611fec
to
2fa3df4
Compare
ParthDesai
force-pushed
the
combine-sdk-and-cli-part-1
branch
from
5fcd0c0
to
c6908ba
Compare
ParthDesai
force-pushed
the
combine-sdk-and-cli-part-2
branch
from
2fa3df4
to
d487a52
Compare
ParthDesai
force-pushed
the
combine-sdk-and-cli-part-2
branch
from
d487a52
to
18c46dd
Compare
ParthDesai
force-pushed
the
combine-sdk-and-cli-part-2
branch
from
18c46dd
to
6496b80
Compare
nazar-pc
approved these changes
Jan 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds sdk as workspace member and make pulsar to use the local version instead of github reference.
What is changed?
There are three main changes:
Cargo.tomlandpulsar/Cargo.tomlto addsdk's crates as workspace members.Unfortunately, those two changes are somewhat interconnected, so it is not possible to create separate commits for them.
Note:
Too many force push due to rebasing with the part 1.