Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Upgrade pulsar to gemini-3h #298

Merged
merged 5 commits into from
Feb 10, 2024
Merged

Upgrade pulsar to gemini-3h #298

merged 5 commits into from
Feb 10, 2024

Conversation

ParthDesai
Copy link
Contributor

@ParthDesai ParthDesai commented Feb 6, 2024

Description

This PR upgrades pulsar to gemini-3h-2024-feb-01 release.

Fixes: #280

Copy link
Member

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions and suggestions for improvements, but generally makes sense.

sdk/dsn/src/builder.rs Outdated Show resolved Hide resolved
sdk/dsn/src/builder.rs Show resolved Hide resolved
sdk/farmer/src/lib.rs Outdated Show resolved Hide resolved
sdk/farmer/src/lib.rs Outdated Show resolved Hide resolved
sdk/farmer/src/lib.rs Outdated Show resolved Hide resolved
sdk/farmer/src/metrics.rs Outdated Show resolved Hide resolved
sdk/node/src/chain_spec.rs Show resolved Hide resolved
sdk/node/src/lib.rs Show resolved Hide resolved
sdk/substrate/src/lib.rs Outdated Show resolved Hide resolved
sdk/substrate/src/lib.rs Show resolved Hide resolved
@ParthDesai ParthDesai force-pushed the gemini-3h-exp-build branch 2 times, most recently from 07d38ae to 3073faa Compare February 9, 2024 12:30
@ParthDesai
Copy link
Contributor Author

@nazar-pc As per our discussion yesterday, I have removed metrics integration from this PR. I tried to get in the cli/builder argument alignment between pulsar and monorepo but that is rework of the substrate helper crate in SDK so that too will be in separate PR.

I fixed the pot_external_entropy function, removed un-needed arguments and also made the pulsar up-to-date with gemini-3h-2024-feb-05 release.

nazar-pc
nazar-pc previously approved these changes Feb 9, 2024
@ParthDesai
Copy link
Contributor Author

@nazar-pc Had to re-enable the filter to only run slow test on linux as macos and windows test are too slow and causes intermittent failure. Can you review this PR once again?

@ParthDesai ParthDesai merged commit b100b0d into main Feb 10, 2024
10 checks passed
@ParthDesai ParthDesai deleted the gemini-3h-exp-build branch February 10, 2024 15:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pruning mode should be ArchiveCanonical
2 participants