Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rh_kselftests_vm.mm: makes shared machine memory #4197

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

mcasquer
Copy link
Contributor

@mcasquer mcasquer commented Nov 6, 2024

rh_kselftests_vm.mm: makes shared machine memory

Implementing a suggestion where it would be better
using shared memory with memory-backend-file.

Signed-off-by: mcasquer mcasquer@redhat.com
ID: 3004

@mcasquer
Copy link
Contributor Author

mcasquer commented Nov 6, 2024

 (1/1) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.rh_kselftests_vm.mm.q35: STARTED
 (1/1) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.rh_kselftests_vm.mm.q35: PASS (313.47 s)
RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

@mcasquer mcasquer marked this pull request as ready for review November 6, 2024 07:16
@mcasquer
Copy link
Contributor Author

mcasquer commented Nov 6, 2024

@YongxueHong @zhencliu please, could you review this PR? Thanks !

@yanan-fu
Copy link
Contributor

yanan-fu commented Nov 7, 2024

@fbq815 For s390x part ~

Copy link
Contributor

@fbq815 fbq815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
RHEL.9.5.0.s390x.io-github-autotest-qemu.rh_kselftests_vm.mm.s390-virtio: PASS

@mcasquer
Copy link
Contributor Author

It seems the PR could be merged :)

@zhencliu
Copy link
Contributor

hi @yanan-fu , would you like to have a double check please?

Copy link
Contributor

@YongxueHong YongxueHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yanan-fu
Copy link
Contributor

@mcasquer Please help rebase it, and we can merge it once rebase done, thanks!

@mcasquer
Copy link
Contributor Author

@mcasquer Please help rebase it, and we can merge it once rebase done, thanks!

Done !

@yanan-fu
Copy link
Contributor

@mcasquer Please help rebase it, and we can merge it once rebase done, thanks!

Done !

I see it still out-of-date, can you double confirm, thanks!

Implementing a suggestion where it would be better
using shared memory with memory-backend-file.

Signed-off-by: mcasquer <mcasquer@redhat.com>
@mcasquer
Copy link
Contributor Author

A patch got merged 30 minutes ago :) rebased again

@yanan-fu yanan-fu merged commit 5a44c70 into autotest:master Nov 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants