Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build tax content file for location async #160

Open
wants to merge 2 commits into
base: 21.3.2
Choose a base branch
from

Conversation

joshwaldrep
Copy link

Fixes the incorrect deserialization of the BuildTaxContentFileForLocationAsync method. The response is an array of tax locations, item codes, and rates. The SDK is trying to deserialize it into a FileResult Object. The call always fails on the deserialization.

I couldn't find a class that matched the return values of the API so I added one. If there is an existing class, that would probably be better. I had to assume the data types based on the values returned by calling the API directly and looking through the other model classes.

I don't know Avalara's documentation standards so there will probably be some updates needed before this is merged.

I didn't find anything in the tests project that references this method.

@joshwaldrep
Copy link
Author

There's an open issue for this, but I don't have access to link it. Invalid response type BuildTaxContentFile(ForLocation)(Async) #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant