Skip to content

Commit

Permalink
Merge pull request #23 from astoundcommerce/feature/AVASUP-325
Browse files Browse the repository at this point in the history
feature/AVASUP-325 Updated documentation for 2.1.0 version
  • Loading branch information
akhoma-astound authored Aug 5, 2019
2 parents 9ac7527 + 8309e93 commit 10fcb6b
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion Plugin/Sales/Admin/Order/Create/Form/Account.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public function afterToHtml(\Magento\Sales\Block\Adminhtml\Order\Create\Form\Acc
{
if ($this->avaTaxConfigHelper->isModuleEnabled()) {
$html = '<div>';
$html .= __('If you are changing a customer group that affects tax calculation, please see <a href="https://github.com/classyllama/ClassyLlama_AvaTax/blob/develop/docs/getting-started.md#admin-order-create-sales-tax-issue" target="_blank">this readme</a> for how to ensure the appropriate taxes are calculated.');
$html .= __('If you are changing a customer group that affects tax calculation, please see <a href="https://github.com/avadev/Avalara-AvaTax-for-Magento2/blob/develop/docs/getting-started.md#admin-order-create-sales-tax-issue" target="_blank">this readme</a> for how to ensure the appropriate taxes are calculated.');
$html .= '</div>';

$result .= $html;
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ This extension contains integration tests to verify the extension's functionalit

# Magento Version Support

- Magento 2.3.x (as of ClassyLlama_AvaTax 1.5.0)
- Magento 2.3.x
- :white_check_mark: Community
- :white_check_mark: Enterprise
- Magento 2.2.x (as of ClassyLlama_AvaTax 1.2.3)
- Magento 2.2.x
- :white_check_mark: Community
- :white_check_mark: Enterprise
- Magento 2.1.x
Expand Down
4 changes: 2 additions & 2 deletions docs/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ This is the recommended installation method as it allows you to easily update th
1. Require the desired version of AvaTax (see [note above](#version-notes) for differences in the versions). Latest version can be installed by running following command:

```
composer require avalara/avatax-magento:2.0.4-RC1
composer require avalara/avatax-magento:2.1.0
```

2. Setup the AvaTax module in magento
Expand All @@ -84,7 +84,7 @@ Only use this installation method if you're unable to use Composer. The installa

3. Extract the file and copy the contents of the ClassyLlama_AvaTax-XXX directory into the `app/code/ClassyLlama/AvaTax` directory.

4. Make sure the [Avalara AvaTax PHP library](https://github.com/avadev/AvaTax-Calc-SOAP-PHP/tree/v15.5.1.0) is installed as the module depends on it.
4. Make sure the [Avalara AvaTax PHP library](https://github.com/avadev/AvaTax-Calc-SOAP-PHP/tree/v15.5.2) is installed as the module depends on it.

```bash
composer require avalara/avatax:15.5.2.0
Expand Down
4 changes: 2 additions & 2 deletions docs/sales-tax.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ A cron task runs every five minutes to send invoices and credit memos to AvaTax.
3. The comment text underneath each of the options in this section should explain the purpose of the setting, but here are some notes about some of the settings:
- <a name="filter_by_region">**Filter Tax Calculation By Region**
- Avalara's recommendation is to leave this option set to the default of **No**. With this option set to **No**, Magento will contact Avalara's API for all regions when tax is being calculated in Magento. This will result in more API calls to AvaTax, however based on how Avalara charges for API calls, the impact of these additional API calls may be minimal or non-existent. Read more about how Avalara charges for API calls [here](https://www.avalara.com/us/en/legal/avatax-terms.html). If your site has a large number of people calculating tax (whether in the cart or checkout), but not placing an order, then the 10:1 ratio of "API calls" vs "Documents Recorded" may make it more expensive to have all API calls sent to Avalara for regions where taxes are not being calculated. Here is an overview of how many API calls are made for a standard Magento checkout:
- Guest checkout (user adds one product to cart, proceeds to checkout, enters shipping address, and then finishes placing order): 3 API calls are sent to Avalara ([screenshot](https://github.com/classyllama/ClassyLlama_AvaTax/blob/develop/docs/images/screenshot_tax_requests_customer.jpg?raw=true))
- Customer checkout (user logs in, adds one product to cart, proceeds to checkout, leaves pre-existing shispping address selected, and then finishes placing order): 2 API calls are sent to Avalara ([screenshot](https://github.com/classyllama/ClassyLlama_AvaTax/blob/develop/docs/images/screenshot_tax_requests_guest.jpg?raw=true))
- Guest checkout (user adds one product to cart, proceeds to checkout, enters shipping address, and then finishes placing order): 3 API calls are sent to Avalara ([screenshot](https://github.com/avadev/Avalara-AvaTax-for-Magento2/blob/develop/docs/images/screenshot_tax_requests_customer.jpg?raw=true))
- Customer checkout (user logs in, adds one product to cart, proceeds to checkout, leaves pre-existing shispping address selected, and then finishes placing order): 2 API calls are sent to Avalara ([screenshot](https://github.com/avadev/Avalara-AvaTax-for-Magento2/blob/develop/docs/images/screenshot_tax_requests_guest.jpg?raw=true))
- If you change the option to **Yes**, Magento will only contact the AvaTax API for regions where you have a tax nexus. However this may cause issues in the future if you need to see all historical transactions in Avalara, and it might affect report reconciling. Talk to your Avalara support representative before changing this to **No**.
- This setting does _not_ limit API requests for Address Validation
- **Data Mapping — Shipping SKU, Adjustment Refund SKU, Adjustment Fee SKU, Gift Wrap Order SKU, Gift Wrap Items SKU, and Gift Wrap Printed Card SKU:** SKUs sent to AvaTax for the associated event. For example, when tax is requested for a single-product order sent to state X, it's possible state X charges tax on shipping. Therefore, two products will be sent in the request: one for the cart item and another for shipping. The correct shipping tax code (FR020100) will always be sent; however, this allows you to customize the SKU in case you want to add custom functionality in your AvaTax dashboard. The same is true when creating a Credit Memo with an adjustment refund or fee in the Magento Admin.
Expand Down
2 changes: 1 addition & 1 deletion etc/adminhtml/system.xml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
<config_path>tax/avatax/filter_tax_by_region</config_path>
<label>Filter Tax Calculation By Region</label>
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
<comment><![CDATA[Should tax calculation only apply to certain regions? Only change this to <strong>Yes</strong> if you have a specific reason to do so. See the [documentation](https://github.com/classyllama/ClassyLlama_AvaTax/blob/develop/docs/sales-tax.md#filter_by_region) for more details.]]></comment>
<comment><![CDATA[Should tax calculation only apply to certain regions? Only change this to <strong>Yes</strong> if you have a specific reason to do so. See the [documentation](https://github.com/avadev/Avalara-AvaTax-for-Magento2/blob/develop/docs/sales-tax.md#filter_by_region) for more details.]]></comment>
<depends>
<field id="enabled">1</field>
<field id="tax_mode" negative="1">1</field>
Expand Down

0 comments on commit 10fcb6b

Please sign in to comment.