Merge pull request #34 from astoundcommerce/fix/AVASUP-425

fix/AVASUP-425 Error with exemptions created and edited in Avalara AP
avadev · Nov 18, 2019 · fb6c261 · fb6c261
2 parents d62d49e + c961bb1
commit fb6c261
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/Controller/Certificates/Download.php b/Controller/Certificates/Download.php
@@ -85,9 +85,14 @@ public function execute(): ResultInterface
             return $result;
         } else {
             if (null === $result || ($result instanceof DataObject && $result->hasData('error'))) {
-                $this->messageManager->addError(
-                    __('Something went wrong, please check the log file for more information')
-                );
+                $codeExplainInfo = __('Something went wrong, please check the log file for more information');
+
+                if($result->getData('error')['code'] == '400'){
+                    $codeExplainInfo = __('The certificate file can\'t be displayed. 
+                    It hasn\'t been generated or upload to the AvaTax Service early.');
+                };
+
+                $this->messageManager->addError($codeExplainInfo);
             }
             /** @var \Magento\Framework\Controller\Result\Redirect $resultRedirect */
             $resultRedirect = $this->resultFactory->create(ResultFactory::TYPE_REDIRECT);

diff --git a/Helper/CertificateDownloadControllerHelper.php b/Helper/CertificateDownloadControllerHelper.php
@@ -156,7 +156,8 @@ public function getDownloadRawResult()
             $errorData = [
                 'class' => self::class,
                 'trace' => $exception->getTraceAsString(),
-                'error_message' => $exception->getMessage()
+                'error_message' => $exception->getMessage(),
+                'code' => $exception->getCode()
             ];
             $this->logger->error($exception->getMessage(), $errorData);
             /** @var \Magento\Framework\DataObject $error */