Updated fork to use v0.3.11 & made points public #1

ToufeeqP · 2024-10-01T09:57:39Z

this commit has our changes

Commentary is reformatted as a result of goimports' update.

@maschad

Prompted by @maschad in supranational#149.

The typo is benign because vec384 and vec256 are indistinguishable when used as arguments to a function, both are pointers to the first limb.

@dannywillems

Prompted by @dannywillems in supranational#152.

Fixes supranational#137.

Fixes supranational#154.

Fixes supranational#157.

Fixes supranational#156.

Unlike gcc, clang refuses to compile vec_nbits() as constexpr. Hence this breaking change.

Trouble is that cc-rs fails to pass proper --target to the C compiler, unless it's specifically clang.

Fixes supranational#172.

vec_cswap is not actually used, or rather the macros that reference it are not used, so it's a just-in-case fix.

Add from(const uint32_t a[2*n]) method that yields reduced result in representation suitable for usage as scalar in EC multiplication.

Fixes supranational#171.

…ently.

Fixes supranational#161.

SWIG-based bindings require only SWIG-specific symbols to be accesible in corresponding shared libraries.

@blukat29

Thanks to Yunjong Jeong (@blukat29) for report.

Aphoh · 2024-10-08T14:06:21Z

I think I found a way to make the msm api work against the regular blst fork:

@ToufeeqP poly-multiproof references upstream blst now:
https://github.com/Aphoh/poly-multiproof/blob/7beaeb68d6fc866d464e724851d469998ff0c2e3/Cargo.toml#L20

See the logic put together in the MSMEngine wrapper I built around both blst and arkworks:

https://github.com/Aphoh/poly-multiproof/blob/7beaeb68d6fc866d464e724851d469998ff0c2e3/src/msm.rs#L220

Not sure where else you're using this, but it might be helpful to pull in that file (or just use the MSMEngine api from poly-multiproof).

ToufeeqP · 2024-10-08T15:49:58Z

I think I found a way to make the msm api work against the regular blst fork:

@ToufeeqP poly-multiproof references upstream blst now: https://github.com/Aphoh/poly-multiproof/blob/7beaeb68d6fc866d464e724851d469998ff0c2e3/Cargo.toml#L20

See the logic put together in the MSMEngine wrapper I built around both blst and arkworks:

https://github.com/Aphoh/poly-multiproof/blob/7beaeb68d6fc866d464e724851d469998ff0c2e3/src/msm.rs#L220

Not sure where else you're using this, but it might be helpful to pull in that file (or just use the MSMEngine api from poly-multiproof).

Hey @Aphoh, thanks for looking into it! I believe this is also being used in avail-core, but we specifically needed blst version 0.3.11 due to deps in the bridge pallet. However, we’ve decided not to use that library directly in the pallet for now, so I’ll go ahead and close this PR. If we need it in the future, I can reopen it

dot-asm and others added 30 commits March 4, 2023 10:18

bindings/go/blst_minpk_test.go: drop deprecated import.

308c119

bindings/go/blst.go: re-generate.py.

764b3da

Commentary is reformatted as a result of goimports' update.

bindings/node.js/run.me: refine node version detection.

d334254

Prompted by @maschad in supranational#149.

build/bindings_trim.pl: replace ::std:: with ::core:: in Rust bindings.

6464ce8

bindings/rust/build.rs: prepare for bare-metal targets.

296b0da

bindings/rust/src/lib.rs: move pippenger_mult_impl to a separate file.

9f5536a

pentaroot.c: fix typos in private prototypes.

0b92a22

The typo is benign because vec384 and vec256 are indistinguishable when used as arguments to a function, both are pointers to the first limb.

bindings/blst.hpp: modernize memory handling.

411e1c6

bindings/blst[_aux].h: make in compile with -Wstrict-prototypes

f4a7953

Prompted by @dannywillems in supranational#152.

bindings/go/blst.go: add CoreVerifyPkInG{1,2}.

7911e7b

Fixes supranational#137.

blst_t.hpp: make operator^ work with larger powers.

6366474

blst_t.hpp: add czero() method.

a7fd1f5

bindings/rust/README.md: fix the exmaple snippets.

c9e57e9

Fixes supranational#154.

bindings/blst_aux.h: fix MSVC compilation error.

e9dfc5e

Fixes supranational#157.

bindings/rust/build.rs: prioritize explicit --codegen target-cpu=*.

9bf52f8

Fixes supranational#156.

bindings/rust/build.rs: fix clippy nits.

63d5886

.github/workflows/ci.yml: resolve Actions deprecation warnings.

97b180e

build.sh: fix ADX detection on Darwin.

9347d5f

bindings/emscripten/run.me: use ${EMSDK_NODE} as a fallback.

80da888

bindings/c#/run.me: utilize ResolvingUnmanagedDll event.

bf83cb6

.github/workflows/codeql-analysis.yml: fix globs in paths.

42865fa

blst_t.hpp: add degree, mem_t and one(or_zero) method.

d3f9bd3

blst_t.hpp: make it compile with clang.

0bec08c

Unlike gcc, clang refuses to compile vec_nbits() as constexpr. Hence this breaking change.

blst_t.hpp: add is_one() methods.

53a303f

bingings/blst.h: move blst_fr_pentaroot to blst_aux.h.

a7a560d

pairing.c: add add blst_miller_loop_n.

97479e7

bindings/blst.h: add blst_miller_loop_n declaration.

056e391

Execute build/refresh.sh.

36f694f

bindings/go/blst.go: add Fp12MillerLoopN.

392c738

bindings/rust/src/pippenger.rs: facilitate $points' slicing.

f0b107b

dot-asm and others added 26 commits June 16, 2023 21:38

bindings/rust/build.rs: refine no_std detection.

16de009

.github/workflows/ci.yml: exercise no-std [with limited stack size].

6b837a0

bindings/rust/Cargo.toml: harmonize with detection logic in build.rs.

1d11baf

bindings/rust/build.rs: default to clang when targeting uefi.

5358144

Trouble is that cc-rs fails to pass proper --target to the C compiler, unless it's specifically clang.

asm/arm-xlate.pl: handle .comm on 64-bit Apple OSes.

e0f3398

Execute build/refresh.sh.

8714a9a

Fixes supranational#172.

vect.h: omit redundant declaration.

c205f7a

vect.h: secure vec_cswap.

5176127

vec_cswap is not actually used, or rather the macros that reference it are not used, so it's a just-in-case fix.

blst_t.hpp: harmonize with <sppark>/ff/mont_t.cuh.

d5a3b78

Add from(const uint32_t a[2*n]) method that yields reduced result in representation suitable for usage as scalar in EC multiplication.

exports.c: refactor blst_scalar_from_{lb}e_bytes.

121ad65

bindings/go: deduplicate cgo files.

4967efe

Fixes supranational#171.

bindings/blst.hpp: resolve -Wmismatched-new-delete.

327d30a

multi_scalar.c: handle small amount of points in Pippenger MSM differ…

168ff67

…ently.

bindings/rust/src/pippenger-test_mod.rs: exercize new code path.

92628b7

*: fix some typos

8e5ecc9

Fixes supranational#161.

Execute build/refresh.sh.

dce883b

asm/ct_*: add missing .hidden directives.

701e42a

Execute build/refresh.sh.

6dd7aa4

cpuid.c: adjust symbol visibility.

492319a

build.sh: drop --version-script linker argument.

e1a44c9

bindings/<swig-based>/*: minimize dynamic library symbol pollution.

5aa7ce1

SWIG-based bindings require only SWIG-specific symbols to be accesible in corresponding shared libraries.

vect.h: tolerate compilation with -std=cNM flag.

9fa8bcf

build.sh: don't pass -mno-avx unless actually required.

c6a3cc0

bindings/go/blst.go: fix logical error in SigValidate.

fb91221

Thanks to Yunjong Jeong (@blukat29) for report.

bindings/rust/Cargo.toml: bump the version number.

3dd0f80

make points public

afdb0a4

ToufeeqP requested a review from Aphoh October 1, 2024 09:58

ToufeeqP closed this Oct 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated fork to use v0.3.11 & made points public #1

Updated fork to use v0.3.11 & made points public #1

ToufeeqP commented Oct 1, 2024

Aphoh commented Oct 8, 2024

ToufeeqP commented Oct 8, 2024

Updated fork to use v0.3.11 & made points public #1

Updated fork to use v0.3.11 & made points public #1

Conversation

ToufeeqP commented Oct 1, 2024

Aphoh commented Oct 8, 2024

ToufeeqP commented Oct 8, 2024