Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is the purpose of SimpleEventSource? #5

Open
bkmeneguello opened this issue Feb 6, 2017 · 1 comment
Open

What is the purpose of SimpleEventSource? #5

bkmeneguello opened this issue Feb 6, 2017 · 1 comment

Comments

@bkmeneguello
Copy link
Contributor

bkmeneguello commented Feb 6, 2017 •
edited by avarabyeu
Loading

I'm using SimpleEventSource to create an EventSource to custom event scheduling, not necessarily periodic. But I notice that "produceEvent" must be implemented. For me this make no sense, because if I want do send my own events anytime, it's my responsibility to invoke "sendEvent".
This said, I pretend to submit a PR removing the "produceEvent" method and removing the necessity of define a frequency to this class of event sources.
@bkmeneguello
Copy link
Contributor Author

If accepted, the PR is #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bkmeneguello