Allow building on Linux ARM64 #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bumped into the same issue. This PR seems legit. |
from "Add macos aarch64 build support to Shakefile system") This partially reverts commit 173d7cd.
Configure MacOS ARM64 release builds
|
Huh, github seems confused about the list of commits after I fixed the merge conflicts here. 🤷 Merging. |
|
Thanks! This is on |
|
Awesome, thanks a lot! Would you mind releasing a new version so that the builds show in the release and also in the npm archives? |
|
The release is tracked here: https://github.com/avh4/elm-format/milestone/31 Basically I have to do a test run of the new npm publishing process, then get linux-aarch64 binaries to build on CI, then take a look at building musl binaries, and then do the release. 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would address #714 and #765. It's similar to #769.
These changes allow
elm-formatto be built on an ARM64 (AArch64) Linux machine. I have tested them with AMD64 (x86-64) as well, which continues to work as expected.