Properly fix (this time for good) the performance issue with continuo…

…us vertical mode
avluis · May 15, 2019 · 14c3eaa · 14c3eaa
1 parent bbbb3fe
commit 14c3eaa
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/app/src/main/java/me/devsaki/hentoid/adapters/ImageRecyclerAdapter.java b/app/src/main/java/me/devsaki/hentoid/adapters/ImageRecyclerAdapter.java
@@ -16,6 +16,7 @@
 import me.devsaki.hentoid.R;
 import me.devsaki.hentoid.util.ImageLoaderThreadExecutor;
 import me.devsaki.hentoid.util.Preferences;
+import timber.log.Timber;
 
 
 public final class ImageRecyclerAdapter extends RecyclerView.Adapter<ImageRecyclerAdapter.ImageViewHolder> {
@@ -77,6 +78,7 @@ private ImageViewHolder(@NonNull View itemView) {
         void setImageUri(String uri) {
             imgView.recycle();
             imgView.setMinimumScaleType(getScaleType());
+Timber.i(">>>>IMG %s", uri);
             imgView.setImage(ImageSource.uri(uri));
         }
 

diff --git a/app/src/main/java/me/devsaki/hentoid/fragments/viewer/ImagePagerFragment.java b/app/src/main/java/me/devsaki/hentoid/fragments/viewer/ImagePagerFragment.java
@@ -82,7 +82,7 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat
                 .observe(this, this::onImagesChanged);
 
         if (Preferences.isViewerResumeLastLeft())
-            new Handler().postDelayed(() -> recyclerView.scrollToPosition(viewModel.getInitialPosition()), 200);
+            recyclerView.scrollToPosition(viewModel.getInitialPosition());
     }
 
     @Override
@@ -124,6 +124,7 @@ private void initPager(View rootView) {
 
         llm = new PrefetchLinearLayoutManager(getContext());
         llm.setItemPrefetchEnabled(true);
+        llm.setPreloadItemCount(2);
         recyclerView.setLayoutManager(llm);
 
         pageSnapWidget = new PageSnapWidget(recyclerView)
@@ -267,8 +268,6 @@ public void onBrowseModeChange() {
         llm.setReverseLayout(Preferences.getViewerDirection() != currentLayoutDirection);
 
         llm.setOrientation(getOrientation());
-        // Lighten the load of preloading images when using vertical mode
-        llm.setPreloadItemCount(Preferences.Constant.PREF_VIEWER_ORIENTATION_HORIZONTAL == Preferences.getViewerOrientation() ? 2 : 1);
         pageSnapWidget.setPageSnapEnabled(Preferences.Constant.PREF_VIEWER_ORIENTATION_VERTICAL != Preferences.getViewerOrientation());
     }
 

diff --git a/app/src/main/res/layout/item_viewer_image.xml b/app/src/main/res/layout/item_viewer_image.xml
@@ -1,4 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <com.davemorrissey.labs.subscaleview.SubsamplingScaleImageView xmlns:android="http://schemas.android.com/apk/res/android"
     android:layout_width="match_parent"
-    android:layout_height="match_parent" />
+    android:layout_height="match_parent"
+    android:minHeight="300dp"
+    />