Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot import name 'packaging' from 'pkg_resources' fix #5942

Merged
merged 1 commit into from
May 30, 2024

Conversation

richtja
Copy link
Contributor

@richtja richtja commented May 29, 2024

In the setuptools>=70 the pkg_resources is deprecated and some of its features might cause troubles. These changes have impact on avocado CI with python3.12. This commit uses directly the packaging package instead of pkg_resources which solves the CI issues.

Reference:
https://setuptools.pypa.io/en/stable/pkg_resources.html#package-discovery-and-resource-access-using-pkg-resources

The CI failures can be seen here.

In the setuptools>=70 the `pkg_resources` is deprecated and some of its
features might cause troubles. These changes have impact on avocado CI
with python3.12. This commit uses directly the `packaging` package
instead of `pkg_resources` which solves the CI issues.

Reference:
https://setuptools.pypa.io/en/stable/pkg_resources.html#package-discovery-and-resource-access-using-pkg-resources
Signed-off-by: Jan Richter <jarichte@redhat.com>
Copy link
Contributor

@harvey0100 harvey0100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Approving.

@richtja richtja merged commit 60b0ffc into avocado-framework:master May 30, 2024
56 of 57 checks passed
@richtja richtja deleted the import_packaging_fix branch May 30, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants