Job logging: introduce buffered behavior #5950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces an option that adds the buffering layer on top of the file logging handler. Plamen Dimitrov has reported issues with heavy logging causing the status server/client connection to reset. He has suggested and has been using a workaround like this. Reference: avocado-framework#5881 Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu
force-pushed
the
output_buffered_handler
branch
from
8587a8b
to
d3dfbd1
Compare
richtja
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Hi @clebergnu, it LGTM. I will wait for @pevogam to have a chance to review it before the merge.
|
Great progress @clebergnu! I will likely be able to take a look at this some time tomorrow. |
pevogam
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an option that adds the buffering layer on top of the file logging handler.
Plamen Dimitrov has reported issues with heavy logging causing the status server/client connection to reset. He has suggested and has been using a workaround like this.
Reference: #5881