Pylint update to 3.0.0 #5959
Merged
Pylint update to 3.0.0 #5959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clebergnu
requested changes
Jun 25, 2024
Thanks @clebergnu, I will investigate it. I am wondering why it wasn't caught on our CI. See https://github.com/avocado-framework/avocado/actions/runs/9549221339/job/26353906359?pr=5959#step:8:16 |
I looked into this, and I found that As opposed to this which uses the "right" version: IMO, |
|
Hello @clebergnu @richtja, I debugged a bit, pylint-3.0 introduced this commit: pylint-dev/pylint@d203de7 Spelling only check |
|
Hi @PaulYuuu, thank you for your help. I will update the spellcheck command and the spell dict. |
|
Hi @clebergnu and @PaulYuuu, thank you for your reviews. I have force-pushed the fix for spell check. Please have a look. |
harvey0100
approved these changes
Jun 27, 2024
richtja
force-pushed
the
pylint_update
branch
5 times, most recently
from
7db9433
to
a50d623
Compare
PaulYuuu
reviewed
Jul 10, 2024
.github/workflows/ci.yml
Outdated
Comment on lines
31
to
33
| run: | | ||
| export PATH=/github/home/.local/bin:$PATH | ||
| python3 setup.py test --select=static-checks |
There was a problem hiding this comment.
Hello @richtja, as we can ensure pylint will be installed during make requirements-dev, can we modify those shell scripts to use tools directly like isort.sh/style.sh, without which pylint, so we don't need this change I think.
There was a problem hiding this comment.
Or use pylint-3, seems it will be installed to /usr/bin/
There was a problem hiding this comment.
Hi @PaulYuuu thanks for your help. I removed the pylint-3 because of this comment.
The reason for export is that those scripts fails in CI without any logs. I am not sure why it fails with python3 -m pylint therefore I'm moving this to draft, and I will add more verbosity to it to find out what is going on in CI environment.
richtja
force-pushed
the
pylint_update
branch
4 times, most recently
from
e8026f6
to
613518e
Compare
|
Hi @clebergnu and @PaulYuuu, I did a couple of tests and at the end I decided to use only python module of pylint as the most stable solution. Please have a look. |
PaulYuuu
approved these changes
Jul 10, 2024
This will update the pylint to version 3.0.0 without enabling any new checks. This is needed because, the pylint 2.17.2 is not compatible with python3.12 Reference: avocado-framework#5957 Signed-off-by: Jan Richter <jarichte@redhat.com>
Avocado is using pylint-3 instead of default pylint. This is a leftover from the time when avocado supported python2. Unfortunately, the pylint-3 has slightly different behaviour than pylint, therefore we need to update it to have more accurate testing. Lets use python3 -m pylint Signed-off-by: Jan Richter <jarichte@redhat.com>
I will do. Thanks for catching that. |
The pylints spelling only check C0401 C0402 C0403, but `--errors-only` in the avocado spell check command line means pylint E rules only, therefore the avocado spell check is not working. This commit removes the `--errors-only` flag and fixes all spelling issues accumulated in avocado code. Signed-off-by: Jan Richter <jarichte@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will update the pylint to version 3.0.0 without enabling any new checks. This is needed because, the pylint 2.17.2 is not compatible with python3.12
Reference: #5957