Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarkupSafe fix #6040

Merged
merged 2 commits into from
Oct 10, 2024
Merged

MarkupSafe fix #6040

merged 2 commits into from
Oct 10, 2024

Conversation

richtja
Copy link
Contributor

@richtja richtja commented Oct 10, 2024

This adds markupsafe<3.0.0 requirements to html plugin, because
markupsafe-3.0.0 can't be installed with older versions of setuptools on
RHEL9 and other systems because of CCompilerError.

Reference: #6038
Signed-off-by: Jan Richter jarichte@redhat.com


We have the same issue in our CI and this PR should fix it.

@richtja richtja added the bug label Oct 10, 2024
@richtja richtja self-assigned this Oct 10, 2024
@richtja richtja added this to the 109 - Codename TBD milestone Oct 10, 2024
@richtja richtja force-pushed the MarkupSafe_fix branch 2 times, most recently from ac42cb3 to 86e67fc Compare October 10, 2024 08:36
This adds markupsafe<3.0.0 requirements to html plugin, because
markupsafe-3.0.0 can't be installed with older versions of setuptools on
RHEL9 and other systems because of `CCompilerError`.

We need to add the same requirement to `ansible` plugin,
because it would try to install markupsafe-3.0.0

Reference: avocado-framework#6038
Signed-off-by: Jan Richter <jarichte@redhat.com>
Signed-off-by: Jan Richter <jarichte@redhat.com>
@richtja richtja changed the title Markup safe fix MarkupSafe fix Oct 10, 2024
Copy link
Contributor

@harvey0100 harvey0100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@richtja richtja merged commit ae1b209 into avocado-framework:master Oct 10, 2024
58 checks passed
@richtja richtja deleted the MarkupSafe_fix branch October 10, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done 109
Development

Successfully merging this pull request may close these issues.

Failed to install MarkupSafe when installing the html plugin via python3 setup.py install
2 participants