Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variable 'hint_resolutions' #6062

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

KeyLee123
Copy link

  • Removed the unused variable hint_resolutions from the resolve function.
  • Directly used the dictionary comprehension to populate hint_references from hint.get_resolutions().
  • Simplified the logic by eliminating an unnecessary intermediate variable.

- Removed the unused variable `hint_resolutions` from the `resolve` function.
- Directly used the dictionary comprehension to populate `hint_references` from `hint.get_resolutions()`.
- Simplified the logic by eliminating an unnecessary intermediate variable.

Signed-off-by: lixu <lixu@uniontech.com>
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.46%. Comparing base (bf9b3d5) to head (6b55d5a).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
avocado/core/resolver.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6062      +/-   ##
==========================================
+ Coverage   54.45%   54.46%   +0.01%     
==========================================
  Files         202      202              
  Lines       21885    21883       -2     
==========================================
+ Hits        11917    11919       +2     
+ Misses       9968     9964       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KeyLee123, thank you for the update it LGTM.

@richtja richtja merged commit c094fde into avocado-framework:master Nov 1, 2024
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 109
Development

Successfully merging this pull request may close these issues.

2 participants