Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: test running the built avrdude executable #1888

Merged
merged 6 commits into from
Aug 24, 2024
Merged

CI: test running the built avrdude executable #1888

merged 6 commits into from
Aug 24, 2024

Commits on Aug 24, 2024

  1. ci: consistently rename macos -autotools build 

    Use the same suffix string "-autotools" for "macos-x86_64-autotools"
which the linux-x86_64-autotools build already uses.
    @ndim
    ndim committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    fb74e28 View commit details
    Browse the repository at this point in the history

  2. ci: Use printf(1) to avoid echo(1) problems 

    Use printf(1) to avoid possible echo(1) incompatibilities like
special escape sequences and the like.

Also, "\n\n" means two linefeeds, without any implicit linefeeds
being added.

Thought for the future: Perhaps test-avrdude should run isatty()
and, if it is not a TTY, not wait for linefeeds at all in the non-
interactive case?
    @ndim
    ndim committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    6e2152f View commit details
    Browse the repository at this point in the history

  3. ci: disable distcheck (until am doc builds have been fixed) 

    The doc builds are a bit brittle at this time, and therefore
do not work reliably with "make distcheck".

Therefore this comments out "make distcheck" until the am doc
builds have been fixed.
    @ndim
    ndim committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    184b00d View commit details
    Browse the repository at this point in the history

  4. ci: Run test-avrdude with -v to show avrdude output on errors

    @ndim
    ndim committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    0603211 View commit details
    Browse the repository at this point in the history

  5. ci: Use ${{env.BUILD_TYPE}} instead of hardcoded value

    @ndim
    ndim committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    415b397 View commit details
    Browse the repository at this point in the history

  6. ci: Where possible, dryrun tests on uninstalled avrdude 

    This tries running the uninstalled avrdude executable, both
with -? and for test-avrdude.

Tests on installed avrdude are kept where they exist,
but not added for all possible platforms.

Quick table showing

  * -? testing of built avrdude (print the usage)
  * dryrun testing of built avrdude before installation
  * installation of avrdude
  * dryrun testing of installed avrdude

and whether that happens/succeeds/fails:

                              run    test              test
                               -?    built   install   installed
    linux-x86_64-autotools  | yes  | succ  | yes     | succ
    linux-x86_64            | yes  | succ  | yes     | succ
    linux (cross-compile)   | yes# | n/a   | no      | <--
    macos-x86_64            | yes  | succ  | no      | <--
    macos-x86_64-autotools  | yes  | succ  | no      | <--
    msvc                    | yes* | succ  | broken  | <--
    mingw                   | yes  | fail  | no      | <--

 # Only on i386, as the armhf and arm64 executables are not runnable
   on the ubuntu-latest x86_64 worker.

 * Works on x86 and x64. Skipped on arm64 at this time.

   The arm64 executable is not runnable, possibly due to the
   old problem of an exe being built for the wrong architecture
   (which @mcuee mentioned somewhere).

In summary, this should run as much as is possible at this time
without introducing failures.

In the future, after these failures are fixed, more tests can be
added for a more complete coverage.
    @ndim
    ndim committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    c677974 View commit details
    Browse the repository at this point in the history