Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.yml to re-enable Windows on ARM64 MSVC build #1901

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

mcuee
Copy link
Collaborator

@mcuee mcuee commented Aug 22, 2024

Previously there is an issue that CMake will pick up the wrong Python installation for the Windows ARM64 build. The issue is now gone. So we can re-enable Windows on ARM64 MSVC build.

@mcuee mcuee added the enhancement New feature or request label Aug 22, 2024
@mcuee
Copy link
Collaborator Author

mcuee commented Aug 22, 2024

Previous issue was found during testing of PR #1714.

@mcuee
Copy link
Collaborator Author

mcuee commented Aug 22, 2024

Now it is okay.

https://github.com/avrdudes/avrdude/actions/runs/10505259376/job/29102454048?pr=1901

-- Found SWIG: C:/ProgramData/chocolatey/bin/swig.exe (found suitable version "4.1.1", minimum required is "4.0") found components: python
-- Could NOT find Python3 (missing: Python3_EXECUTABLE Interpreter) (found version "3.12.4")
    Reason given by package: 
        Interpreter: Wrong architecture for the interpreter "C:/hostedtoolcache/windows/Python/3.9.13/x64/python.exe"

@mcuee
Copy link
Collaborator Author

mcuee commented Aug 22, 2024

@ndim @stefanrueger @MCUdude and @dl8dtl

Further enhancement is to install Python 3 for Windows on ARM64.

But I think we can leave that post 8.0 release.

Any objections?

@mcuee
Copy link
Collaborator Author

mcuee commented Aug 22, 2024

@stefanrueger

This should be safe to be merged.

@ndim

I see that you have this change in #1888 as well. But I am not so sure if PR #1888 can be ready for 8.0 release.

@ndim
Copy link
Contributor

ndim commented Aug 22, 2024

@ndim

I see that you have this change in #1888 as well. But I am not so sure if PR #1888 can be ready for 8.0 release.

I am sure #1888 will not be ready for 8.0 release.

@mcuee I will gladly rebase #1888 on top of whatever you have already made to work.

@stefanrueger stefanrueger merged commit 2cd9e5b into avrdudes:main Aug 23, 2024
13 checks passed
@mcuee mcuee deleted the windows_arm64_build branch September 1, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants