Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added Gotenberg, a Docker-powered stateless API for PDF files #1090

Merged
merged 8 commits into from
Jan 19, 2025

Conversation

nktnet1
Copy link
Contributor

@nktnet1 nktnet1 commented Jan 8, 2025

Thanks for taking the time to suggest an addition to awesome-selfhosted!

To ensure your Pull Request is dealt with swiftly, please check the following (check the boxes [x]):

  • Submit one item per pull request. This eases reviewing and speeds up inclusion.
  • You have searched the repository for any relevant issues or PRs, including closed ones.
  • Any software you are adding is not already listed at any of awesome-sysadmin, staticgen.com, staticsitegenerators.net, dbdb.io.
  • The file you are adding is formatted as described in addition.md.
  • Demo links should only be used for interactive demos, i.e. not video demonstrations.
  • Comments and unused optional fields have been removed.
  • The file you are adding uses kebab-case file naming, for example my-awesome-software.yml.
  • Values for platform are the main server-side requirements for the software. Don't include frameworks or specific dialects.
  • Any software project you are adding to the list is actively maintained.
  • Any software project you are adding was first released more than 4 months ago.
  • Any software project you are adding has working installation instructions.
  • You understand that your Pull Request will be merged ~1 week after approval, to allow for further comments if needed.

@Ki-er Ki-er added addition Adding new software to the list reviewers wanted Awaiting reviews labels Jan 8, 2025
software/gotenberg.yml Outdated Show resolved Hide resolved
software/gotenberg.yml Outdated Show resolved Hide resolved
software/gotenberg.yml Outdated Show resolved Hide resolved
nktnet1 and others added 3 commits January 9, 2025 00:31
Co-authored-by: Kieran <32241933+Ki-er@users.noreply.github.com>
Co-authored-by: Kieran <32241933+Ki-er@users.noreply.github.com>
Co-authored-by: Kieran <32241933+Ki-er@users.noreply.github.com>
Copy link
Collaborator

@Rabenherz112 Rabenherz112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only list end-user applications, as far as I see Gotenberg doesn't have a direct way for end-users to interact with it (such as a webui), but instead solely relies on their API.

@nktnet1
Copy link
Contributor Author

nktnet1 commented Jan 8, 2025

We only list end-user applications, as far as I see Gotenberg doesn't have a direct way for end-users to interact with it (such as a webui), but instead solely relies on their API.

I see... thank you for the review and clarification @Rabenherz112.

This wasn't obvious to me from the descriptions on the original awesome-selfhosted repository:

github-about

awesome-selfhosted-home

I thought Gotenberg would've at the least fallen under the Network Service category that was linked.

I also noticed similar Server/API-based/CLI projects (added a few more just now) such as

so I thought it would've been okay to add Gotenberg.
However, I've only skimmed over these, so perhaps they satisfied the WebUI requirement in some other way (e.g. vaultwarden I supposed can be paired with the Bitwarden frontend?)

Would you like me to close this pull request?

@nodiscc nodiscc added the discussion General discussion label Jan 8, 2025
@nodiscc nodiscc self-requested a review January 8, 2025 23:14
software/gotenberg.yml Outdated Show resolved Hide resolved
@nodiscc nodiscc removed the discussion General discussion label Jan 9, 2025
Copy link
Collaborator

@Ki-er Ki-er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly cleaner description

software/gotenberg.yml Outdated Show resolved Hide resolved
Frok Ki-er

Co-authored-by: Kieran <32241933+Ki-er@users.noreply.github.com>
software/gotenberg.yml Outdated Show resolved Hide resolved
From Ki-Er

Co-authored-by: Kieran <32241933+Ki-er@users.noreply.github.com>
@nodiscc nodiscc self-requested a review January 11, 2025 10:38
Copy link
Member

@nodiscc nodiscc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disregard the linter error, unrelated

@nodiscc nodiscc removed the reviewers wanted Awaiting reviews label Jan 11, 2025
@nktnet1 nktnet1 requested a review from Ki-er January 11, 2025 11:34
@nktnet1
Copy link
Contributor Author

nktnet1 commented Jan 17, 2025

I've merged the main branch into this one, which did remove the unrelared lint issue ^_^.

@nodiscc nodiscc merged commit c3e6cd2 into awesome-selfhosted:master Jan 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition Adding new software to the list
Development

Successfully merging this pull request may close these issues.

4 participants