Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PULL_REQUEST_TEMPLATE.md: clarify demo credentials requirements #1105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PULL_REQUEST_TEMPLATE.md: clarify demo credentials requirements #1105

wants to merge 1 commit into from

Conversation

nodiscc
Copy link
Member

@nodiscc nodiscc commented Jan 14, 2025

Following the very confusing review process in #1028, clarify what is expected in the demo_url field.

@nodiscc nodiscc added documentation Improvements or additions to documentation enhancement New feature or request reviewers wanted Awaiting reviews labels Jan 14, 2025
Ki-er
Ki-er approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@Ki-er Ki-er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better

@Ki-er
Copy link
Collaborator

Ki-er commented Jan 14, 2025 •
edited
Loading

What is our stance on login but no demo credentials linked, i.e the user needs to create an account? example: Bitcart has authentication but no login details are provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ki-er Ki-er Ki-er approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request reviewers wanted Awaiting reviews
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nodiscc @Ki-er