Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Storage): Removing testable import on PresignURL extension #3878

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

ruisebas
Copy link
Member

@ruisebas ruisebas commented Sep 19, 2024

Issue #

Description

Removing the testable annotation when importing AWSS3 which was added because some types became internal. Instead, I'm replicating the types locally.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ruisebas ruisebas marked this pull request as ready for review September 19, 2024 17:22
@ruisebas ruisebas requested a review from a team as a code owner September 19, 2024 17:22
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 51 lines in your changes missing coverage. Please review.

Project coverage is 68.20%. Comparing base (1ec20d0) to head (5fbfd6a).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...Plugin/Dependency/UploadPartInput+presignURL.swift 0.00% 51 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3878      +/-   ##
==========================================
+ Coverage   68.14%   68.20%   +0.06%     
==========================================
  Files        1085     1085              
  Lines       37992    38040      +48     
==========================================
+ Hits        25889    25945      +56     
+ Misses      12103    12095       -8     
Flag Coverage Δ
API_plugin_unit_test 69.32% <ø> (ø)
AWSPluginsCore 68.53% <ø> (ø)
Amplify 47.12% <ø> (+0.01%) ⬆️
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 79.30% <ø> (-0.09%) ⬇️
DataStore_plugin_unit_test 82.17% <ø> (+0.94%) ⬆️
Geo_plugin_unit_test 72.06% <ø> (ø)
Logging_plugin_unit_test 62.99% <ø> (ø)
Predictions_plugin_unit_test 35.94% <ø> (ø)
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 75.46% <0.00%> (-1.03%) ⬇️
unit_tests 68.20% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruisebas ruisebas merged commit 0a49967 into main Sep 19, 2024
83 checks passed
@ruisebas ruisebas deleted the ruisebas/remove_testable branch September 19, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants