fix(docker): During cfn submit docker commands were not working on Windows
#208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fails it will add warning message
mmaeng
changed the title
cfn submit docker commands were not working on Windows
kddejong
approved these changes
Nov 1, 2022
ericzbeard
approved these changes
Nov 4, 2022
mmaeng
added a commit
to mmaeng/cloudformation-cli-python-plugin
that referenced
this pull request
Nov 8, 2022
…Windows (aws-cloudformation#208) * When on windows will not use os.geteuid() but root:root, also if call fails it will add warning message * Change test for docker no euid to work on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #100
Docker command to run container was getting the local user euid and gid. These attributes do not exist on non-UNIX-like OSes like Windows.
Put in check for the command to complete successfully but if not to default to root:root. Windows ignores these attributes and the Docker file system has built in safeguards around this.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.