Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS::CloudFormation::StackInstance - New Resource #103

Open
benbridts opened this issue Aug 5, 2019 · 7 comments
Open

AWS::CloudFormation::StackInstance - New Resource #103

benbridts opened this issue Aug 5, 2019 · 7 comments
Labels
enhancement New feature or request management & governance CloudWatch, Auto Scaling, CloudTrail, Config, OpsWorks, Service Catalog, etc.

Comments

@benbridts
Copy link

  1. Title -> AWS::CloudFormation::StackInstance
  2. Scope of request -> A StackInstance resource that can be used to add Stacks to a StackSet
  3. Expected behavior -> It takes a !Ref to a StackSet (see AWS::CloudFormation::StackSet - New Resource #102), an AccountId and a Region. One StackInstance should be exactly one account+region.
  4. Links to existing API doc (optional) -> https://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_CreateStackInstances.html
  5. Category tag (optional) -> Management & Governance
  6. Any additional context (optional)
    The API allows creating mulitple stack instances at the same time. This may be a possible way to do it, but I think that having one Resource per Instance makes more sense in a CloudFormation template.
@TheDanBlanco TheDanBlanco added the management & governance CloudWatch, Auto Scaling, CloudTrail, Config, OpsWorks, Service Catalog, etc. label Aug 6, 2019
@piersf
Copy link

piersf commented Jun 25, 2020

Hi all,

Are there any updates or any estimation when this will be implemented? Having this feature adds massive value to our ability to use StackSets with AWS Organizations for governance at scale.

Thank you!

@piersf
Copy link

piersf commented Sep 24, 2020

@benbridts
Copy link
Author

benbridts commented Sep 24, 2020

That unfortunately does not allow you to add a stack instance to an existing stack stack set :(

@piersf
Copy link

piersf commented Sep 25, 2020

@ikben what do you mean?

@rafalwrzeszcz
Copy link

@ikben It's not stated (probably documentation not updated) but you can import existing stack set. There is however other big limitation: https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-cloudformation/blob/master/aws-cloudformation-stackset/src/main/java/software/amazon/cloudformation/stackset/util/Validator.java#L20 you can not deploy StackSet with nesteed stacks with this solution.

I created an issue for that aws-cloudformation/aws-cloudformation-resource-providers-cloudformation#16

@benbridts
Copy link
Author

Sorry, I forgot a word.
The current resources do not allow you to create a Stack Instance in an existing Stack Set.

Or in other words: You cannot create the StackSet in one template/stack and have another template/stack create a StackInstance in that StackSet.

You would run into this if you want to deploy from an account-centric standpoint instead of a stack-set-centric one. In the account-centric approach, you could have one stack per account, that registers a Stack Instance in all the relevant Stack Sets (which allows you to determine the order of the StackSets)

@WaelA WaelA added the enhancement New feature or request label Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request management & governance CloudWatch, Auto Scaling, CloudTrail, Config, OpsWorks, Service Catalog, etc.
Projects
None yet
Development

No branches or pull requests

5 participants