fix: do not use eval

aws-greengrass · Nov 27, 2023 · 3648fc2 · 3648fc2
1 parent 9d54a25
commit 3648fc2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/gdk/CLIParser.py b/gdk/CLIParser.py
@@ -154,7 +154,7 @@ def _get_arg_from_model(self, argument):
             if param in argument and param != "name":
                 modified_arg[param] = argument[param]
             if param in argument and param == "type":
-                modified_arg[param] = eval(argument[param])
+                modified_arg[param] = getattr(utils, argument[param])
         return argument["name"], modified_arg
 
     def _add_common_args_for_all_commands(self):

diff --git a/gdk/common/utils.py b/gdk/common/utils.py
@@ -151,6 +151,9 @@ def is_recipe_size_valid(file_path):
     file_size = Path(file_path).stat().st_size
     return file_size <= MAX_RECIPE_FILE_SIZE_BYTES, file_size
 
+def convertToLowercase(value):
+  return str.lower(value)
+
 
 error_line = "\n=============================== ERROR ===============================\n"
 help_line = "\n=============================== HELP ===============================\n"

diff --git a/gdk/static/cli_model.json b/gdk/static/cli_model.json
@@ -15,7 +15,7 @@
                                     "python",
                                     "java"
                                 ],
-                                "type": "str.lower"
+                                "type": "convertToLowercase"
                             },
                             "template": {
                                 "name": [