Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not use eval #267

Merged
merged 1 commit into from
Nov 27, 2023
Merged

fix: do not use eval #267

merged 1 commit into from
Nov 27, 2023

Conversation

saranyailla
Copy link
Member

Issue #, if available:

Description of changes:

Why is this change necessary:

How was this change tested:

Any additional information or context required to review the change:

Checklist:

  • Updated the README if applicable
  • Updated or added new unit tests
  • Updated or added new integration tests
  • Updated or added new end-to-end tests
  • If your code makes a remote network call, it was tested with a proxy
  • You confirm that the change is backwards compatible

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d54a25) 97.87% compared to head (b1edbf7) 70.83%.

Additional details and impacted files
@@               Coverage Diff                @@
##           development     #267       +/-   ##
================================================
- Coverage        97.87%   70.83%   -27.04%     
================================================
  Files               48       48               
  Lines             1884     1886        +2     
================================================
- Hits              1844     1336      -508     
- Misses              40      550      +510     
Flag Coverage Δ
integ ?
uat 70.83% <100.00%> (+0.03%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saranyailla saranyailla merged commit 542de22 into development Nov 27, 2023
4 of 5 checks passed
@saranyailla saranyailla deleted the fix-eval branch November 27, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants