Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cli and dependencies installation to CI steps #280

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

patrzhan
Copy link
Member

@patrzhan patrzhan commented Jan 13, 2024

Issue #, if available:

Description of changes:
During our CI steps add installation of the CLI/its dependencies. We do this in our regression steps but doing this here will help us spot issues sooner.

Why is this change necessary:
Help spot issues sooner.

How was this change tested:
Workflow on this PR. At the time of writing, the workflows are failing as #279 fix is still waiting to be merged.

Any additional information or context required to review the change:

Checklist:

  • Updated the README if applicable
  • Updated or added new unit tests
  • Updated or added new integration tests
  • Updated or added new end-to-end tests
  • If your code makes a remote network call, it was tested with a proxy
  • You confirm that the change is backwards compatible

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@patrzhan patrzhan marked this pull request as ready for review January 13, 2024 01:06
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (439da5d) 97.92% compared to head (cc130e7) 97.92%.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #280   +/-   ##
============================================
  Coverage        97.92%   97.92%           
============================================
  Files               49       49           
  Lines             1927     1927           
============================================
  Hits              1887     1887           
  Misses              40       40           
Flag Coverage Δ
integ 81.00% <ø> (ø)
uat 71.66% <ø> (-0.06%) ⬇️
unit 93.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@patrzhan patrzhan merged commit a662a92 into development Jan 16, 2024
5 checks passed
@patrzhan patrzhan deleted the add-install-to-ci branch January 16, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants