Merge pull request #510 from andrew-glenn/remove_import_session

removing import_session

taskcat/_client_factory.py

@@ -31,19 +31,6 @@ def __init__(self, _boto3=boto3):
         self._account_info: Dict[str, Dict[str, str]] = {}
         self._lock_cache_update = False
 
-    def import_session(self, session_suffix, session: boto3.Session, region: str):
-        """
-        Under edge cases, it may be necessary to import a pre-defined session
-        into the cache. Imported sessions will be cached with the prefix
-        'imported_session_', and can be used with that prefix.
-        ex:
-            <boto3Cache_instance>.import_session('us-east-1', session)
-           ec2 =  <boto3Cache_Instance>.get('ec2', profile='imported_session_us-east-1')
-        """
-        self._cache_set(
-            self._session_cache, [f"imported_session_{session_suffix}", region], session
-        )
-
     def session(self, profile: str = "default", region: str = None) -> boto3.Session:
         region = self._get_region(region, profile)
         try:
@@ -196,9 +183,6 @@ def _get_partition(self, profile):
         raise ValueError("cannot find suitable AWS partition")
 
     def get_default_region(self, profile_name="default") -> str:
-        if profile_name.startswith("imported_session_"):
-            _, region = self._get_partition(profile_name)
-            return region
         try:
             region = self._boto3.session.Session(profile_name=profile_name).region_name
         except ProfileNotFound:

tests/test_client_factory.py

@@ -30,16 +30,6 @@ def test_session_invalid_profile(self, mock_cache_lookup, mock_cache_set):
             cache.session(profile="non-existent-profile")
         self.assertEqual(mock_cache_lookup.called, True)
 
-    @mock.patch("taskcat._client_factory.Boto3Cache._cache_set", autospec=True)
-    @mock.patch("taskcat._client_factory.Boto3Cache._cache_lookup", autospec=True)
-    @mock.patch("taskcat._client_factory.boto3.Session", autospec=True)
-    def test_imported_session(self, mock_boto3, mock_cache_lookup, mock_cache_set):
-        x = Boto3Cache()
-        x.import_session("foobar", mock_boto3, "us-east-1")
-        mock_cache_set.assert_called_with(
-            x, x._session_cache, ["imported_session_foobar", "us-east-1"], mock_boto3
-        )
-
     @mock.patch("taskcat._client_factory.Boto3Cache._get_partition", autospec=True)
     @mock.patch("taskcat._client_factory.Boto3Cache._cache_set", autospec=True)
     @mock.patch("taskcat._client_factory.Boto3Cache._cache_lookup", autospec=True)