Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

Workshop code is not matching import statements generated by CDK v2 #1049

Closed
Tracked by #1170
evgenyka opened this issue Jun 1, 2023 · 1 comment
Closed
Tracked by #1170
Labels
bug This issue is a bug. cdk-v2 Issues related to or generated by the changes implemented in CDKv2 effort/medium Medium work item – a couple days of effort p2

Comments

@evgenyka
Copy link

evgenyka commented Jun 1, 2023

Describe the bug

The code in CDK workshop is outdated and not matching the latest CDK.

Expected Behavior

The updated import statements are:

import { Duration, Stack, StackProps } from 'aws-cdk-lib';
import * as sns from 'aws-cdk-lib/aws-sns';
import * as subs from 'aws-cdk-lib/aws-sns-subscriptions';
import * as sqs from 'aws-cdk-lib/aws-sqs';
import { Construct } from 'constructs';

Current Behavior

The code in CDK workshop is outdated and not matching the latest CDK.

Reproduction Steps

Go to Project Structure page.
Find The main stack.
The import statements are:

import * as cdk from 'aws-cdk-lib';
import * as sns from 'aws-cdk-lib/aws-sns';
import * as subs from 'aws-cdk-lib/aws-sns-subscriptions';
import * as sqs from 'aws-cdk-lib/aws-sqs';

Possible Solution

Update the code in the Workshop to match the latest CDK version generated code.

Additional Information/Context

No response

CDK CLI Version

No response

Section

No response

Browser

No response

Language

TypeScript

@evgenyka evgenyka added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jun 1, 2023
@indrora indrora added effort/medium Medium work item – a couple days of effort cdk-v2 Issues related to or generated by the changes implemented in CDKv2 and removed needs-triage This issue or PR still needs to be triaged. labels Jun 1, 2023
@indrora indrora mentioned this issue Sep 13, 2023
23 tasks
@kellertk kellertk closed this as completed Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. cdk-v2 Issues related to or generated by the changes implemented in CDKv2 effort/medium Medium work item – a couple days of effort p2
Projects
None yet
Development

No branches or pull requests

4 participants