Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

cdk-dynamo-table-viewer@0.2.46 fails deployment #1139

Closed
Tracked by #1170
vinayak-kukreja opened this issue Aug 18, 2023 · 4 comments · Fixed by #1394
Closed
Tracked by #1170

cdk-dynamo-table-viewer@0.2.46 fails deployment #1139

vinayak-kukreja opened this issue Aug 18, 2023 · 4 comments · Fixed by #1394
Assignees
@ashishdhingra
Labels
bug This issue is a bug. p1

Comments

@vinayak-kukreja
Copy link

vinayak-kukreja commented Aug 18, 2023 •
edited
Loading

Describe the bug

This is due to the library having node 12 which is now not supported.

Expected Behavior

Deployment succeeds

Current Behavior

Resource handler returned message: "The runtime parameter of nodejs12.x is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs18.x) while creating or updating functions.

Reproduction Steps

Follow steps here: https://cdkworkshop.com/20-typescript/50-table-viewer.html

Possible Solution

Upgrade to version 0.2.486 or above.

PR which fixed node version in library.

Additional Information/Context

No response

CDK CLI Version

2.92.0 (build bf62e55)

Section

Using Construct Libraries

Browser

Firefox

Language

Typescript
@vinayak-kukreja vinayak-kukreja added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Aug 18, 2023
@vinayak-kukreja vinayak-kukreja mentioned this issue Aug 18, 2023
Closed
@indrora indrora mentioned this issue Sep 13, 2023
Closed
23 tasks
@voluntary-hardship
Copy link

Confirmed this.
"Installing the library" instructions specify a verision of cdk-dynamo-table-viewer that is no longer supported (cdk-dynamo-table-viewer@0.2.46) and results in cdk deploy error & rollback.
https://cdkworkshop.com/20-typescript/50-table-viewer/200-install.html
Fix it by specifying the latest cdk-dynamo-table-viewer version from https://www.npmjs.com/package/cdk-dynamo-table-viewer?activeTab=versions

@ashishdhingra
Copy link
Contributor

ashishdhingra commented Apr 16, 2024 •
edited
Loading

@vinayak-kukreja Thanks for the PR contribution. We will get this reviewed and merged.

nit: Would you like to update your PR to refer the current latest version cdk-dynamo-table-viewer@0.2.488?

@ashishdhingra ashishdhingra added p1 pr/needs-review This PR needs a review from a Member. and removed needs-triage This issue or PR still needs to be triaged. labels Apr 16, 2024
@ashishdhingra
Copy link
Contributor

@vinayak-kukreja There is another issue #1231 which mentions the version issue for other languages. I will create consolidated PR for updating version of cdk-dynamo-table-view for all languages.

@ashishdhingra ashishdhingra self-assigned this Apr 17, 2024
@ashishdhingra ashishdhingra removed the pr/needs-review This PR needs a review from a Member. label Apr 17, 2024
@ashishdhingra ashishdhingra mentioned this issue Apr 17, 2024
Merged
@mergify mergify bot closed this as completed in #1394 Apr 17, 2024
mergify bot pushed a commit that referenced this issue Apr 17, 2024
@ashishdhingra
feat: Bump CDK Dynamo Table Viewer dependency. (#1394)
9d2129d 
- Bump CDK Dynamo Table Viewer dependency.
- Use CSS class for Prev/Next links rendered for a section.



Fixes #1139
Fixes #1231

---

By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT-0 License].

[MIT-0 License]: https://github.com/aws/mit-0/blob/master/MIT-0
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ashishdhingra ashishdhingra

Labels
bug This issue is a bug. p1
Projects
None yet
Milestone
No milestone
3 participants
@ashishdhingra @vinayak-kukreja @voluntary-hardship