Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

Inconsistent use of cdk (command) and npx cdk (command) #1188

Closed
scanlonp opened this issue Sep 25, 2023 · 4 comments
Closed

Inconsistent use of cdk (command) and npx cdk (command) #1188

scanlonp opened this issue Sep 25, 2023 · 4 comments
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@scanlonp
Copy link

scanlonp commented Sep 25, 2023

Describe the bug

In the pipelines workshop, deploy commands are done by npx cdk deploy. In all sections leading up to this, they are cdk deploy. This should not affect the behavior of the code, but is inconsistent.

I can open a pull for this.

Expected Behavior

Standardized CLI commands.

Current Behavior

Mix of CLI commands.

Reproduction Steps

This page
vs
this page

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

No response

Section

No response

Browser

No response

Language

Typescript

@scanlonp scanlonp added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 25, 2023
@ashishdhingra ashishdhingra added p2 and removed needs-triage This issue or PR still needs to be triaged. labels Apr 16, 2024
@ashishdhingra
Copy link
Contributor

@scanlonp Thanks for pointing the inconsistency. Feel free to contribute PR with a fix. Please ensure the following:

  • Make the changes for all language workshops, for both English and Japanese languages
  • Ensure locally that omitting npx works.

Thanks,
Ashish

@ashishdhingra ashishdhingra added the effort/small Small work item – less than a day of effort label Apr 16, 2024
@stefanfreitag
Copy link
Contributor

@scanlonp @ashishdhingra I have some capacity left and if you both are fine, I can look into this.

@ashishdhingra
Copy link
Contributor

@scanlonp @ashishdhingra I have some capacity left and if you both are fine, I can look into this.

@stefanfreitag Sure. Thanks.

Copy link

github-actions bot commented Aug 1, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants