Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

.gitignore does not work in "Lambda handler のコード" section of TypeScript (Japanese version) #1460

Closed
ScArLeXiA opened this issue Jul 3, 2024 · 1 comment
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@ScArLeXiA
Copy link

Describe the bug

The optional prefix "!" negates the gitignore pattern, but the Japanese version uses the unique concept of "full-width characters" used in CJK text.
Therefore, it does not work.

Half-width (correct) Full-width
!

It is easy for me to create a pull request on this issue.

Expected Behavior

lambda/*.js will be tracked by Git.

Current Behavior

Since full-width characters are used, the intended behavior is not realized as in the English version.

Reproduction Steps

$ mkdir cdk-workshop && cd cdk-workshop
$ npx cdk init sample-app --language typescript
$ git status
On branch main
Untracked files:
  (use "git add <file>..." to include in what will be committed)
        package-lock.json

nothing added to commit but untracked files present (use "git add" to track)
$ mkdir lambda/
$ touch lambda/hello.js
$ vim .gitignore         # Add `!lambda/*.js` and save
$ git status             # `lambda/hello.js` is ignored
On branch main
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   .gitignore

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        package-lock.json

no changes added to commit (use "git add" and/or "git commit -a")

Possible Solution

Correct to half-width characters.

Additional Information/Context

No response

CDK CLI Version

2.147.3 (build 32f0fdb)

Section

Lambda handler のコード

Browser

Google Chrome 126.0.6478.126 (Official Build) (64 bit)

Language

TypeScript

@ScArLeXiA ScArLeXiA added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 3, 2024
@ScArLeXiA ScArLeXiA changed the title .gitignore does not work in "Lambda handler のコード" section of TypeScript ( Japanese version) .gitignore does not work in "Lambda handler のコード" section of TypeScript (Japanese version) Jul 5, 2024
@kellertk kellertk closed this as completed Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants