Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update container name to match deployment server default value in index.jsp #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gr3mlin
Copy link
Contributor

@gr3mlin gr3mlin commented Apr 19, 2017

Changed to match default CloudFormation production VM deployment name so this container shows on the deployment server render.

Changed to match default CloudFormation production VM deployment name so this container shows on the deployment server render.
@gr3mlin gr3mlin changed the title Update index.jsp Update container name to match deployment server default value in index.jsp Apr 19, 2017
Copy link

@asaf-erlich asaf-erlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello gr3mlin,

What testing have you done to verify this works? Happy to approve it as long as it's been tested at least manually using your own forked repo.

Thanks,
-Asaf

@gr3mlin
Copy link
Contributor Author

gr3mlin commented Jul 8, 2017

Sorry for the months late response, I tested this at the time on my test AWS instances for demos I was providing but I havn't touched the code in a couple months. I'll recheck and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants