Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected RAM Share names for subnets to include the VPC Name #22

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Corrected RAM Share names for subnets to include the VPC Name #22

merged 1 commit into from
Sep 15, 2023

Conversation

apmclean
Copy link
Contributor

Fix for bug #18

RAM Share names now include the VPC Name from the configuration file instead of just the VPC Style

- Added missing test cases for Public Subnet Style.
@apmclean apmclean linked an issue Sep 15, 2023 that may be closed by this pull request
@apmclean apmclean self-assigned this Sep 15, 2023
@apmclean apmclean added the bug Something isn't working label Sep 15, 2023
@apmclean apmclean merged commit f2303dd into aws-samples:main Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resulting RAM Share names all contain 'Share-workload'
1 participant