upgrade controller-runtime to 0.16.0 #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove leaseonly flag due to deprecated support
jdn5126
approved these changes
Aug 25, 2023
Thanks. Yeah, we should have an issue to track this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove leaseonly flag due to deprecated support
Issue #, if available:
#277
Description of changes:
Controller-runtime just released v0.16.0 which includes changes can benefit this controller,
We need to have these changes to help this controller more resilient in different environments, such as issue VPC RC keeps crashing during cache build stage on clusters with high CRDs #277 .
Tests have been done in dev clusters.
Note: with this change, we need to remove the flag
--lease-onlyfrom manifests.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.