Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/aws/amazon-vpc-cni-k8s from 1.18.1 to 1.18.3 #446

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 1, 2024

Bumps github.com/aws/amazon-vpc-cni-k8s from 1.18.1 to 1.18.3.

Release notes

Sourced from github.com/aws/amazon-vpc-cni-k8s's releases.

v1.18.3

What's Changed

New Contributors

Full Changelog: aws/amazon-vpc-cni-k8s@v1.18.2...v1.18.3

... (truncated)

Changelog

Sourced from github.com/aws/amazon-vpc-cni-k8s's changelog.

v1.18.3

What's Changed

New Contributors

Full Changelog: aws/amazon-vpc-cni-k8s@v1.18.2...v1.18.3

... (truncated)

Commits
  • 128a08e Changelog, Chart Versions and Config Version update for CNI Release v1.18.3 (...
  • 49667a1 Fix Charts Release 1.18 Branch. (#2991)
  • 7f137be Merge changes from master to release-1.18 branch for 1.18.3 release. (#2989)
  • dbd4aa0 Fix the Charts Version for v1.18.2 (#2943)
  • 965f89f Changelog and Updated CNI Charts for v1.18.2 Release (#2942)
  • 6b3beef Fix merge from master to release-1.18 - for VPC CNI 1.18.2 release (#2933)
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested a review from a team as a code owner August 1, 2024 00:37
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 1, 2024
@sushrk
Copy link
Contributor

sushrk commented Sep 19, 2024

@dependabot rebase

Bumps [github.com/aws/amazon-vpc-cni-k8s](https://github.com/aws/amazon-vpc-cni-k8s) from 1.18.1 to 1.18.3.
- [Release notes](https://github.com/aws/amazon-vpc-cni-k8s/releases)
- [Changelog](https://github.com/aws/amazon-vpc-cni-k8s/blob/v1.18.3/CHANGELOG.md)
- [Commits](aws/amazon-vpc-cni-k8s@v1.18.1...v1.18.3)

---
updated-dependencies:
- dependency-name: github.com/aws/amazon-vpc-cni-k8s
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/aws/amazon-vpc-cni-k8s-1.18.3 branch from 0c37477 to 08ac676 Compare September 19, 2024 21:25
@sushrk
Copy link
Contributor

sushrk commented Sep 19, 2024

Fixed admission.decoder type to resolve errors in presubmit check

Error: webhooks/core/annotation_validation_webhook.go:92:22: a.decoder.DecodeRaw undefined (type *admission.Decoder is pointer to interface, not interface)
Error: webhooks/core/annotation_validation_webhook.go:110:22: a.decoder.DecodeRaw undefined (type *admission.Decoder is pointer to interface, not interface)
Error: webhooks/core/annotation_validation_webhook.go:114:22: a.decoder.DecodeRaw undefined (type *admission.Decoder is pointer to interface, not interface)
Error: webhooks/core/node_update_webhook.go:59:22: a.decoder.DecodeRaw undefined (type *admission.Decoder is pointer to interface, not interface)
Error: webhooks/core/node_update_webhook.go:63:22: a.decoder.DecodeRaw undefined (type *admission.Decoder is pointer to interface, not interface)
Error: webhooks/core/pod_webhook.go:83:19: i.decoder.Decode undefined (type *admission.Decoder is pointer to interface, not interface)

admission.Decoder was changed to an interface in controller-runtime v0.18.0 kubernetes-sigs/controller-runtime#2736.

Copy link
Contributor

@yash97 yash97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@sushrk sushrk merged commit 827c2b8 into master Sep 19, 2024
4 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/aws/amazon-vpc-cni-k8s-1.18.3 branch September 19, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants