Passing page limit to cach config instead of override. #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code looks good. I need some time before I can test this. |
|
Hi @GnatorX any update from your scale test? |
|
I was only able to test that it fixed the issue however I currently don't have time to test it at scale. I suspect I won't be able to test at scale for some time. I am peaceful with this change moving forward but will try to report back when I am able to test at scale. |
yash97
added a commit
to yash97/amazon-vpc-resource-controller-k8s
that referenced
this pull request
Sep 10, 2024
* passing page limit to cache config * adding error log to optimized list watcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
solves #412
Description of changes:
As described in issue #412, controller data store gets partially hydrated if it received error 410. This is because reflector calls customized listFunc with page limit set to 0 but code was overwriting page limit, resulting in partial list instead of full list. This PR passes page limit option to cache config struct and let reflector handle state of options.limit as it will change it to 0 if it faces resource expired error.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.