Skipping health check on nodes if EC2 returns throttling errors #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushrk
reviewed
Oct 21, 2024
| @@ -96,6 +98,8 @@ type AsyncOperationJob struct { | |||
| nodeName string | |||
| } | |||
|
|
|||
| const pausingHealthCheckDuration = 30 * time.Minute | |||
There was a problem hiding this comment.
Would it better to try a exponential back off strategy here rather than wait for a fixed amount of time?
Most customers would recover from the failure pretty quickly I assume, we might not want to block health check for 30 mins.
There was a problem hiding this comment.
I would try to avoid more complicate exponential back off for this simple and safe skipping health check. How about 10 minutes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The controller shouldn't health check on resources when the upstream API returns some specific errors, such as EC2 throttling, since those errors are not recoverable by failing the controller.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.