-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(ecr-assets): mention CDK_DOCKER environment variable in README #32586
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!
Co-authored-by: Jimmy Gaussen <jimmy.gaussen@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: Pull request #32586 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (detail: 4 of 6 required status checks are expected.). You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@Mergifyio requeue |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
@aws/aws-cdk-owners should I just wait for getting this merged automatically or do I have anything to do here? |
Issue # (if applicable)
Closes #32585.
Reason for this change
This change adds description that
CDK_DOCKER
environment variable is also effective inaws-ecr-assets
module likeaws-s3-assets
.Description of changes
Just a documentation change. No code change.
Describe any new or updated permissions being added
N/A
Description of how you validated changes
I confirmed the environment variable is effective locally.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license