feat(ecs): enbale fault injection flag #32598
Conversation
github-actions
bot
added
the
distinguished-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32598 +/- ##
==========================================
+ Coverage 79.13% 79.73% +0.60%
==========================================
Files 107 107
Lines 7131 7130 -1
Branches 1319 1320 +1
==========================================
+ Hits 5643 5685 +42
+ Misses 1304 1261 -43
Partials 184 184
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
| memoryLimitMiB: 512, | ||
| }); | ||
|
|
||
| new IntegTest(app, 'TaskDefinitionEnableFaultInjection', { |
There was a problem hiding this comment.
Could you add assertions to a DescribeTaskDefinition API call? You should be able to retrieve the enableFaultInjection prop there
aws-cdk-automation
removed
the
pr/needs-community-review
Co-authored-by: Jimmy Gaussen <jimmy.gaussen@gmail.com>
Co-authored-by: Jimmy Gaussen <jimmy.gaussen@gmail.com>
Co-authored-by: Jimmy Gaussen <jimmy.gaussen@gmail.com>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
N/A
Reason for this change
Add a missing property.
Description of changes
Add
enableFaultInjectionproperty.Describe any new or updated permissions being added
No
<!— What new or updated IAM permissions are needed to support the changes being introduced ? -->
Description of how you validated changes
Add unit test and integ test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license