-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(config): add 3 new resource types #32599
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32599 +/- ##
=======================================
Coverage 79.13% 79.13%
=======================================
Files 107 107
Lines 7131 7131
Branches 1319 1319
=======================================
Hits 5643 5643
Misses 1304 1304
Partials 184 184
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I compared rule.ts
with the documentation, and found these configs are also missing:
AWS::AppConfig::ExtensionAssociation
AWS::Athena::DataCatalog
AWS::Athena::WorkGroup
AWS::Cognito::IdentityPool
AWS::Cognito::UserPool
AWS::Cognito::UserPoolClient
AWS::Cognito::UserPoolGroup
AWS::Config::ConfigurationRecorder
AWS::Detective::Graph
AWS::DMS::Certificate
AWS::DMS::ReplicationInstance
AWS::DMS::ReplicationTask
AWS::EC2::NetworkInsightsAccessScope
AWS::EC2::NetworkInsightsAnalysis
AWS::EC2::VPCBlockPublicAccessOptions
AWS::EKS::FargateProfile
AWS::Evidently::Segment
AWS::GroundStation::DataflowEndpointGroup
AWS::IAM::OIDCProvider
AWS::ImageBuilder::ImageRecipe
AWS::Lambda::Alias
AWS::M2::Environment
AWS::MediaConnect::Gateway
AWS::MemoryDB::SubnetGroup
AWS::MSK::ClusterPolicy
AWS::MSK::VpcConnection
AWS::OpenSearchServerless::VpcEndpoint
AWS::Redshift::EndpointAccess
AWS::Redshift::EndpointAuthorization
AWS::SageMaker::EndpointConfig
AWS::SageMaker::NotebookInstanceLifecycleConfig
AWS::SSM::Document
AWS::Transfer::Profile
There is also a typo for AWS::IoTwinMaker::Workspace
, which should be AWS::IoTTwinMaker::Workspace
Finally, it seems like AWS::EventSchemas::Registry
and AWS::IoTTwinMaker::ComponentType
are gone from Supported Resource Types for AWS Config, so it might be worth deprecating it? Unsure what happened to it
@nmussy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We gotta start thinking about generating this class from the doc page @nmussy linked or some other source of truth 😂
In the meantime there's no way we need to have a static property for every single valud resource type... the whole point of an enum-like class is that you can use of
and define whatever you want.
Add 3 new resource types:
Ref: AWS Config now supports 3 new resource types
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license