feat: mpl externs #1105
Merged
feat: mpl externs #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShubhamChaturvedi7
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
ShubhamChaturvedi7
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
ShubhamChaturvedi7
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
ShubhamChaturvedi7
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
ShubhamChaturvedi7
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
seebees
previously approved these changes
Dec 12, 2024
ShubhamChaturvedi7
dismissed
seebees’s stale review
The merge-base changed after approval.
ShubhamChaturvedi7
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
ShubhamChaturvedi7
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
ShubhamChaturvedi7
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
ShubhamChaturvedi7
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
seebees
requested changes
Dec 17, 2024
| } else if res.Dtor_value().(StormTracker.CacheState).Is_EmptyFetch() { | ||
| return Companion_Default___.CreateGetCacheEntryFailure(AwsCryptographyMaterialProvidersTypes.Companion_Error_.Create_EntryDoesNotExist_(_dafny.SeqOfChars([]_dafny.Char("Entry doesn't exists")...))) | ||
| } else { | ||
| time.Sleep(time.Duration(cmc.stormTracker.SleepMilli)) |
There was a problem hiding this comment.
This needs to keep track of how long it is sleeping. At a minimum, it can be an unbounded wait :)
ShubhamChaturvedi7
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
NOTE: Scope of review here are the directories
AwsCryptographicMaterialProvidersand.github. Everything else is already in review in other PRs and diff would disappear from here when they are merged. You can still review them if you'd like.Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.