chore: verify with 4.6 #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texastony
reviewed
May 30, 2024
| dafnyVersion=4.2.0 | ||
| dafnyVerifyVersion=4.2.0 |
There was a problem hiding this comment.
Question: Do we intend to bump this to 4.6.0?
There was a problem hiding this comment.
We wanted to, but StandardLibrary/UTF8.ValidUTF8Concat doesn't verify in 4.6.0, and it's not clear what to do about it. It currently verifies under nightly, and so once 4.7 is available we'll try again.
seebees
reviewed
May 31, 2024
Co-authored-by: seebees <ryanemer@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.