chore: add rust support #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ial-providers-library into ajewell/rust
…ial-providers-library into ajewell/rust
RitvikKapila
requested changes
Nov 14, 2024
There was a problem hiding this comment.
This looks good overall.
Left a few comments to update Cargo.toml in all projects. A few other nits.
My main comment is to update the test vectors for AES192 to remove Algorithm Suites as well.
Update: I know why the AES192 algorithm suites problem didn't come up in Test Vectors, because we aren't actually running interop tests in Rust. This should include Rust and the library_interop_tests.yml should be similar to the one in the ESDK.
Note: The ESDK one doesn't support Python yet but you don't need to worry about that.
TestVectorsAwsCryptographicMaterialProviders/runtimes/rust/Cargo.toml
Outdated
Show resolved
Hide resolved
...ders/dafny/TestVectorsAwsCryptographicMaterialProviders/src/VectorsComposition/AllRawAES.dfy
Outdated
Show resolved
Hide resolved
RitvikKapila
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.