elfparser: Add method to load BPF from an io.ReaderAt #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it. do you want to add a test too? |
jayanthvn
reviewed
Sep 21, 2023
| func (b *bpfSDKClient) LoadBpfFile(path, customizedPinPath string) (map[string]BpfData, map[string]ebpf_maps.BpfMap, error) { | ||
| bpfFile, err := os.Open(path) | ||
| // LoadBpfFromReader loads ELF file from io.ReaderAt and parses an ELF file into BPF objects | ||
| func (b *bpfSDKClient) LoadBpfFromReader(r io.ReaderAt, customizedPinPath string) ( |
There was a problem hiding this comment.
You need to add it to the - interface type BpfSDKClient
There was a problem hiding this comment.
Oh! Thank you for pointing that out.
Indeed, we needed to add the interface. I've fixed to add.
shun159
force-pushed
the
feature/elf_ioreader
branch
from
bbdb606
to
3e600d3
Compare
|
Hi @dims, Thank you for your review. |
|
I've made fixes based on the feedback. Happy with these changes? |
shun159
force-pushed
the
feature/elf_ioreader
branch
3 times, most recently
from
c9a6296
to
a40bcd0
Compare
- Introduce the `LoadBpfFromReader` method in the `bpfSDKClient`. - This method enables loading ELF files directly from an io.ReaderAt. Signed-off-by: shun159 <dreamdiagnosis@gmail.com>
shun159
force-pushed
the
feature/elf_ioreader
branch
from
a40bcd0
to
8bd332d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the
LoadBpfFromReaderto thebpfSDKClientto load an ELF file from anio.ReaderAt. With this patch, it becomes possible to load an ELF binary embedded in an application binary usinggo:embedas the following: