Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce minimum go version when runnign cmake if go is not disabled #1580

Merged
merged 1 commit into from
May 8, 2024

Conversation

andrewhop
Copy link
Contributor

Description of changes:

The version specified in go.mod isn't enforced and users can hit weird issues when building AWS-LC with old versions of go:

long build output
 util/embed_test_data.go:81:16: undefined: os.ReadFile
more build output
...
 make: *** [Makefile:117: all] Error 2
BUILD FAILED 

This is confusing because the go error can be easily overlooked.

Call-outs:

This change isn't changing what version of Go builders need, just making the requirement more clear.

Testing:

Built locally and verified output -- Go compiler 1.21.3 found I also tried raising the minimum version to 1.180 and verified it failed:

CMake Error at cmake/go.cmake:28 (message):
  Go compiler version must be at least 1.180.  Found version 1.21.3
Call Stack (most recent call first):
  CMakeLists.txt:26 (include)

And if you disable go the configure passes and checks nothing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@andrewhop andrewhop requested a review from a team as a code owner May 7, 2024 23:25
@andrewhop andrewhop requested a review from skmcgrail May 7, 2024 23:25
@andrewhop andrewhop enabled auto-merge (squash) May 8, 2024 00:13
@andrewhop andrewhop merged commit b5e3681 into aws:main May 8, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants