Enforce minimum go version when runnign cmake if go is not disabled #1580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The version specified in go.mod isn't enforced and users can hit weird issues when building AWS-LC with old versions of go:
This is confusing because the go error can be easily overlooked.
Call-outs:
This change isn't changing what version of Go builders need, just making the requirement more clear.
Testing:
Built locally and verified output
-- Go compiler 1.21.3 found
I also tried raising the minimum version to 1.180 and verified it failed:And if you disable go the configure passes and checks nothing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.