-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More minor symbols for Ruby support #1581
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1581 +/- ##
==========================================
- Coverage 78.15% 78.15% -0.01%
==========================================
Files 562 562
Lines 94676 94683 +7
Branches 13576 13576
==========================================
+ Hits 73995 73998 +3
- Misses 20084 20089 +5
+ Partials 597 596 -1 ☔ View full report in Codecov by Sentry. |
samuel40791765
force-pushed
the
pkcs12_new
branch
3 times, most recently
from
May 13, 2024 18:26
484f6d9
to
9964d5d
Compare
samuel40791765
force-pushed
the
pkcs12_new
branch
2 times, most recently
from
May 24, 2024 00:19
35b0e8d
to
f376e4e
Compare
WillChilds-Klein
previously approved these changes
May 31, 2024
andrewhop
reviewed
May 31, 2024
andrewhop
approved these changes
Jun 13, 2024
WillChilds-Klein
approved these changes
Jun 14, 2024
samuel40791765
force-pushed
the
pkcs12_new
branch
from
June 14, 2024 21:33
ef71340
to
de56c61
Compare
lilpoozie2005
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses
CryptoAlg-1717
Description of changes:
This implements two minor symbols and a few no-op flags for Ruby support.
New symbols:
No-op flags:
Call-outs:
All of these no-ops are following a precedent in AWS-LC. We may have to have a discussion on whether to support CONF modules further down the line, but exposing this as a no-op for now.
Testing:
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.