Add integration tests for OpenSSL-linking 3p modules #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1587 +/- ##
==========================================
+ Coverage 77.90% 78.07% +0.17%
==========================================
Files 561 562 +1
Lines 94632 94656 +24
Branches 13604 13574 -30
==========================================
+ Hits 73725 73905 +180
+ Misses 20315 20157 -158
- Partials 592 594 +2 ☔ View full report in Codecov by Sentry. |
WillChilds-Klein
force-pushed
the
python-integration-testing
branch
6 times, most recently
from
3d774f4 to
02a67cd
Compare
justsmth
previously approved these changes
May 23, 2024
We're currently seeing some [odd][1] CI failures in mainline CPython (at time of this commit message that's 3.14). There's some guidance in CPython's 3.12 release notes around setuputils and distutils that may be relevant here. [1]: https://github.com/aws/aws-lc/actions/runs/9037986216/job/24838188660?pr=1587 [2]: https://docs.python.org/3.12/whatsnew/3.12.html
Co-authored-by: Samuel Chiang <sachiang@amazon.com>
WillChilds-Klein
force-pushed
the
python-integration-testing
branch
from
2675f5e to
aab761a
Compare
samuel40791765
approved these changes
Jun 6, 2024
justsmth
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change expands our python integration tests to load and exercise libcrypto-linking 3rd party modules. Cases covered include statically linked AWS-LC (default AWS CRT) and dynamically linked OpenSSL (AWS CRT, PyOpenSSL, PyCA). We also test these integrations with python's AWS-LC built in FIPS mode.
Call-outs:
Due to the pre-release nature of python 3.13 and 3.14, there are a few caveats for later versions: 3.12 introduced a change to drop
setuptoolsfrom default virtual environments, causing installation issues for PyCA and PyOpenSSL on 3.13+. To work around this, we allow installation failure for those dependencies on newer (currently both 3.13 and 3.14 are pre-release) and exit early from the relevant test cases. We also encountered some issues installing CRT bindings from source on 3.12+, so for those versions we install the pre-compiled wheel module from PyPI, which uses AWS-LC under the hood.Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.