add back ASN1_dup with tests

[samuel40791765]

Issues:

Addresses CryptoAlg-1717

Description of changes:

ASN1_dup was removed in 419144a in favor of ASN1_Item_dup. This shouldn't normally be called directly, but Ruby happens to consume the API in several instances.
I've optimized the function to allocate memory with i2d directly, instead of the ancient OpenSSL allocate and pass into behavior.
Also added some tests for verification along with a do-not-use warning.

Call-outs:

N/A

Testing:

New tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 78.06%. Comparing base (94e91d9) to head (fb3e2e7).

Files	Patch %	Lines
crypto/asn1/a_dup.c	75.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1591      +/-   ##
==========================================
+ Coverage   78.03%   78.06%   +0.02%     
==========================================
  Files         562      562              
  Lines       94558    94600      +42     
  Branches    13576    13575       -1     
==========================================
+ Hits        73790    73848      +58     
+ Misses      20175    20160      -15     
+ Partials      593      592       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[samuel40791765]

Apparently the CFI is still failing with the macros:

/codebuild/output/src1171782177/src/github.com/aws/aws-lc/crypto/asn1/a_dup.c:70:17: runtime error: control flow integrity check for type 'int (const void *, unsigned char **)' failed during indirect function call
(/codebuild/output/src1171782177/src/github.com/aws/aws-lc/test_build_dir/crypto/crypto_test+0x3afd5e0): note: i2d_ASN1_TYPE defined here
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /codebuild/output/src1171782177/src/github.com/aws/aws-lc/crypto/asn1/a_dup.c:70:17 in 

I reverted to run 4a5be1e against the CFI sanitizers, but apparently it doesn't actually pass the CFI tests either. I'll need to revert 4a5be1e and 0cd2716 to remove the macros and get the CFI build passing.

I think the main issue is that i2d_of_void and d2i_of_void expect a void parameter, but the typical i2d/d2i functions have a specific type assigned as the parameter. Upon closer reexamination, the macros don't seem to solve this issue. The two CI failures in the commits may show more details.

• 3f37c6f CI run